[PATCH] Add process name to Asan logfile name and report message

Ed Maste emaste at freebsd.org
Fri Oct 10 06:05:43 PDT 2014


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:695-699
@@ -704,7 +694,7 @@
   if (IsErr) {
     // We can't read /proc/self/exe for some reason, assume the name of the
     // binary is unknown.
     Report("WARNING: readlink(\"/proc/self/exe\") failed with errno %d, "
            "some stack frames may not be symbolized\n", readlink_error);
     module_name_len = internal_snprintf(buf, buf_len, "/proc/self/exe");
     CHECK_LT(module_name_len, buf_len);
----------------
Not part of this CL but just noticed while reviewing: it looks like this comment and error message was missed in the SANITIZER_FREEBSD work.  This should either be moved into the individual #if cases above or made into a generic error ("WARNING: reading executable name failed with errno %d")

http://reviews.llvm.org/D5724






More information about the llvm-commits mailing list