[PATCH] [zorg] Add options allowing MSVC builds with Clang Cmake Build Factory.

Renato Golin renato.golin at linaro.org
Fri Oct 10 05:28:00 PDT 2014


Hi Rick,

Can you attach the U99 diffs to the phabricator review? Just go to the top, "Create diff", upload your new files, then chose the current review and it'll update the revision.

About testing, have you tested the Linux build with your changes? It'd be good to get a confirmation that it's not breaking or we'll have a hard time reverting and getting the existing bots back to green again.

I'd like to see this change merged, so that I can add the test-suite run and get a new bot with compiler-rt + test-suite, but only after we're sure that this is working well on both Windows and Linux, and we address all of Galina's concerns.

cheers,
--renato

http://reviews.llvm.org/D5588






More information about the llvm-commits mailing list