[PATCH] Add process name to Asan logfile name and report message

Yury Gribov tetra2005 at gmail.com
Fri Oct 10 04:52:06 PDT 2014


================
Comment at: lib/asan/asan_rtl.cc:566
@@ -565,1 +565,3 @@
 
+  CacheBinaryName();
+
----------------
eugenis wrote:
> Why do you need this?
Sorry, forgot to remove this.

================
Comment at: lib/sanitizer_common/sanitizer_common.cc:261
@@ +260,3 @@
+    atomic_signal_fence(memory_order_seq_cst);
+    atomic_thread_fence(memory_order_seq_cst);
+    proc_self_exe_cache_initialized = true;
----------------
eugenis wrote:
> This is wrong. W/o some kind of synchronization on the read path it would not prevent, for example, prefetching of proc_self_exe_cache_str before checking proc_self_exe_cache_initialized.
> 
> You need release store and acquire load.
> 
Doesn't mutex take care of that?

http://reviews.llvm.org/D5724






More information about the llvm-commits mailing list