[PATCH] Do not split variables definitions into 2 DIEs.

Frederic Riss friss at apple.com
Thu Oct 9 16:19:53 PDT 2014


I finally managed to get some test results for this patch. Indeed putting the static member variable definition broke some lldb tests, thus I left the behavior unchanged for static member variables. This is still a nice cleanup of the global variable DIE creation logic.

David, if you still like the direction I'd appreciate if you could give it a test run on the GDB testsuite to see if it doesn't break anything there. Note that I haven't included an additional test for type units as I removed the behavior change that might have caused issues with that usecase.

http://reviews.llvm.org/D5457

Files:
  lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  test/DebugInfo/X86/gnu-public-names.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5457.14686.patch
Type: text/x-patch
Size: 5962 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141009/8998cded/attachment.bin>


More information about the llvm-commits mailing list