[PATCH] [InstCombine] Fix wrong folding of constant comparisons involving ashr and negative values (PR21222).

Andrea Di Biagio andrea.dibiagio at gmail.com
Thu Oct 9 05:52:41 PDT 2014


Thanks for the review.
Committed revision 219406.

On Thu, Oct 9, 2014 at 1:12 PM, suyog <suyog.sarda at samsung.com> wrote:
> Hi Andrea,
>
> Thanks for investigating and fixing the bug.
> I agree with your point that distance should be calculated using one's compliment
> instead of two's compliment.
>
> LGTM.
>
> http://reviews.llvm.org/D5700
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list