[PATCH] [dwarfdump] Prettyprint DW_AT_APPLE_property_attribute bitfield values.

David Blaikie dblaikie at gmail.com
Wed Oct 8 17:18:00 PDT 2014


Looks reasonable (apart from testing) - depends how you want to do it. I assume there are some existing tests that test properties that could be updated to use this feature? (does this not regress any existing tests?)

If there aren't any such tests, I imagine we want some - and they could just test this incidentally.

(I'm usually on the fence about writing tool tests separately from unit tests... *shrug* sometimes it's nice, sometimes it seems like overkill)

http://reviews.llvm.org/D5689






More information about the llvm-commits mailing list