[PATCH] [Compiler-rt][Sanitizer][MSan][MIPS] Adding support for MIPS32
Alexey Samsonov
vonosmas at gmail.com
Wed Oct 8 14:08:29 PDT 2014
Deferring this to Evgeniy. Just a couple of drive-by comments.
================
Comment at: lib/msan/msan.cc:29
@@ +28,3 @@
+#if defined(__mips__)
+#define TLS_TCB_OFFSET 0x7000
+#define TLS_PRE_TCB_SIZE 0x08
----------------
Can you #define those things where they are actually used for the first time?
================
Comment at: lib/msan/msan.cc:516
@@ -511,1 +515,3 @@
u64 p;
+ #if defined(__mips__)
+ char *ptr;
----------------
#if should start from the beginning of the line:
#if defined(__mips__)
char *ptr;
// more code
#else
// more code
#endif
http://reviews.llvm.org/D5672
More information about the llvm-commits
mailing list