[llvm] r219175 - [InstCombine] re-commit r218721 icmp-select-icmp optimization

Hans Wennborg hans at chromium.org
Tue Oct 7 18:17:39 PDT 2014


On Mon, Oct 6, 2014 at 5:16 PM, Gerolf Hoflehner <ghoflehner at apple.com> wrote:
> Author: ghoflehner
> Date: Mon Oct  6 19:16:12 2014
> New Revision: 219175
>
> URL: http://llvm.org/viewvc/llvm-project?rev=219175&view=rev
> Log:
> [InstCombine] re-commit r218721 icmp-select-icmp optimization
>
> Takes care of the assert that caused build fails.
> Rather than asserting the code checks now that the definition
> and use are in the same block, and does not attempt
> to optimize when that is not the case.

I have reverted this in r219264, as it was causing miscompiles (PR21199).

 - Hans



More information about the llvm-commits mailing list