[llvm] r219110 - For biendian targets like ARM and AArch64, it is useful to have the

Eric Christopher echristo at gmail.com
Mon Oct 6 00:06:03 PDT 2014


Author: echristo
Date: Mon Oct  6 02:06:03 2014
New Revision: 219110

URL: http://llvm.org/viewvc/llvm-project?rev=219110&view=rev
Log:
For biendian targets like ARM and AArch64, it is useful to have the
output of the llvm-dwarfdump and llvm-objdump report the endianness
used when the object files were generated.

Patch by Charlie Turner.

Added:
    llvm/trunk/test/DebugInfo/AArch64/little-endian-dump.ll
      - copied, changed from r219109, llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll
    llvm/trunk/test/DebugInfo/ARM/little-endian-dump.ll
      - copied, changed from r219109, llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll
Modified:
    llvm/trunk/include/llvm/Object/ELFObjectFile.h
    llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll
    llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll

Modified: llvm/trunk/include/llvm/Object/ELFObjectFile.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELFObjectFile.h?rev=219110&r1=219109&r2=219110&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Object/ELFObjectFile.h (original)
+++ llvm/trunk/include/llvm/Object/ELFObjectFile.h Mon Oct  6 02:06:03 2014
@@ -855,6 +855,7 @@ uint8_t ELFObjectFile<ELFT>::getBytesInA
 
 template <class ELFT>
 StringRef ELFObjectFile<ELFT>::getFileFormatName() const {
+  bool IsLittleEndian = ELFT::TargetEndianness == support::little;
   switch (EF.getHeader()->e_ident[ELF::EI_CLASS]) {
   case ELF::ELFCLASS32:
     switch (EF.getHeader()->e_machine) {
@@ -863,7 +864,7 @@ StringRef ELFObjectFile<ELFT>::getFileFo
     case ELF::EM_X86_64:
       return "ELF32-x86-64";
     case ELF::EM_ARM:
-      return "ELF32-arm";
+      return (IsLittleEndian ? "ELF32-arm-little" : "ELF32-arm-big");
     case ELF::EM_HEXAGON:
       return "ELF32-hexagon";
     case ELF::EM_MIPS:
@@ -883,7 +884,7 @@ StringRef ELFObjectFile<ELFT>::getFileFo
     case ELF::EM_X86_64:
       return "ELF64-x86-64";
     case ELF::EM_AARCH64:
-      return "ELF64-aarch64";
+      return (IsLittleEndian ? "ELF64-aarch64-little" : "ELF64-aarch64-big");
     case ELF::EM_PPC64:
       return "ELF64-ppc64";
     case ELF::EM_S390:

Modified: llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll?rev=219110&r1=219109&r2=219110&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll (original)
+++ llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll Mon Oct  6 02:06:03 2014
@@ -1,4 +1,6 @@
-; RUN: llc -O0 -filetype=obj -mtriple=aarch64_be-none-linux < %s | llvm-dwarfdump -
+; RUN: llc -O0 -filetype=obj -mtriple=aarch64_be-none-linux < %s | llvm-dwarfdump - | FileCheck %s
+
+; CHECK: file format ELF64-aarch64-big
 
 target datalayout = "E-m:e-i64:64-i128:128-n32:64-S128"
 

Copied: llvm/trunk/test/DebugInfo/AArch64/little-endian-dump.ll (from r219109, llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll)
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/AArch64/little-endian-dump.ll?p2=llvm/trunk/test/DebugInfo/AArch64/little-endian-dump.ll&p1=llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll&r1=219109&r2=219110&rev=219110&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/AArch64/big-endian-dump.ll (original)
+++ llvm/trunk/test/DebugInfo/AArch64/little-endian-dump.ll Mon Oct  6 02:06:03 2014
@@ -1,6 +1,8 @@
-; RUN: llc -O0 -filetype=obj -mtriple=aarch64_be-none-linux < %s | llvm-dwarfdump -
+; RUN: llc -O0 -filetype=obj -mtriple=aarch64-none-linux < %s | llvm-dwarfdump - | FileCheck %s
 
-target datalayout = "E-m:e-i64:64-i128:128-n32:64-S128"
+; CHECK: file format ELF64-aarch64-little
+
+target datalayout = "e-m:e-i64:64-i128:128-n32:64-S128"
 
 !llvm.dbg.cu = !{!0}
 !llvm.module.flags = !{!3, !4}

Modified: llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll?rev=219110&r1=219109&r2=219110&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll (original)
+++ llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll Mon Oct  6 02:06:03 2014
@@ -1,4 +1,6 @@
-; RUN: llc -O0 -filetype=obj -mtriple=armeb-none-linux < %s | llvm-dwarfdump -
+; RUN: llc -O0 -filetype=obj -mtriple=armeb-none-linux < %s | llvm-dwarfdump - | FileCheck %s
+
+; CHECK: file format ELF32-arm-big
 
 target datalayout = "E-m:e-p:32:32-i64:64-v128:64:128-n32-S64"
 

Copied: llvm/trunk/test/DebugInfo/ARM/little-endian-dump.ll (from r219109, llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll)
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/ARM/little-endian-dump.ll?p2=llvm/trunk/test/DebugInfo/ARM/little-endian-dump.ll&p1=llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll&r1=219109&r2=219110&rev=219110&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/ARM/big-endian-dump.ll (original)
+++ llvm/trunk/test/DebugInfo/ARM/little-endian-dump.ll Mon Oct  6 02:06:03 2014
@@ -1,6 +1,8 @@
-; RUN: llc -O0 -filetype=obj -mtriple=armeb-none-linux < %s | llvm-dwarfdump -
+; RUN: llc -O0 -filetype=obj -mtriple=arm-none-linux < %s | llvm-dwarfdump - | FileCheck %s
 
-target datalayout = "E-m:e-p:32:32-i64:64-v128:64:128-n32-S64"
+; CHECK: file format ELF32-arm-little
+
+target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-n32-S64"
 
 !llvm.dbg.cu = !{!0}
 !llvm.module.flags = !{!3, !4, !5, !6}





More information about the llvm-commits mailing list