[PATCH] Update API to add PIC-level support.

Chad Rosier mcrosier at codeaurora.org
Fri Oct 3 20:50:53 PDT 2014


Just a few nits.

(If this isn't already being done in another patch) Can you add some amount of functionality, so this can be tested in some trivial way?

Unfortunately, I'm not the right person to sign off on this..

================
Comment at: include/llvm/ExecutionEngine/ExecutionEngine.h:586
@@ +585,3 @@
+  /// setPICLevel - Set the PICLevel that the ExecutionEngine target is using.
+  /// Defaults to the target specific default "PICLevel::Default"
+  EngineBuilder &setPICLevel(PICLevel::Level PL) {
----------------
Please add a period.

================
Comment at: include/llvm/MC/MCCodeGenInfo.h:41
@@ -39,1 +40,3 @@
+                           CodeGenOpt::Level OL = CodeGenOpt::Default,
+                           PICLevel::Level PL = PICLevel::Default );
 
----------------
Please remove extra whitespace before " );"

================
Comment at: lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp:112
@@ -110,2 +111,3 @@
   }
-  X->InitMCCodeGenInfo(RM, CM, OL);
+  if (PL == PICLevel::Default) {
+    PL = PICLevel::Large;
----------------
No need for extra braces.

http://reviews.llvm.org/D5332






More information about the llvm-commits mailing list