[PATCH] [compiler_rt] Fix the armv7 thumb buildins on darwin

[Steven Wu]

Thanks for pointing out the typos.

New patch:


> On Oct 3, 2014, at 4:58 PM, Bob Wilson <bob.wilson at apple.com> wrote:
> 
>> 
>> On Oct 3, 2014, at 3:28 PM, Steven Wu <stevenwu at apple.com <mailto:stevenwu at apple.com>> wrote:
>> 
>> Hi
>> 
>> This patch fixes the broken thumb buildins on apple platforms.On apple platforms, .thumb_func directive is required to generated correct symbol for thumb functions. 
>> 
>> From: Steven Wu <stevenwu at apple.com <mailto:stevenwu at apple.com>>
>> Date: Fri, 3 Oct 2014 15:10:52 -0700
>> Subject: [PATCH] Fix the armv7 thumb buildins on darwin
>> 
>> The arm buildins converted into thumb is completely broken on darwin.
> 
> Typo: “buildins” -> “builtins”
> “…is completely…” should be “are completely”.
> 
> Also, please add something to the commit message to reference r213481, which added “.thumb” directives to these functions.
> 
>> On apple platforms, .thumb_func directive is required to generated
>> correct symbol for thumb functions.
> 
> The actual patch is fine. Please commit.
> 
>> ---
>> lib/builtins/arm/bswapdi2.S   |  2 +-
>> lib/builtins/arm/bswapsi2.S   |  2 +-
>> lib/builtins/arm/clzdi2.S     |  2 +-
>> lib/builtins/arm/clzsi2.S     |  2 +-
>> lib/builtins/arm/divmodsi4.S  |  2 +-
>> lib/builtins/arm/divsi3.S     |  2 +-
>> lib/builtins/arm/modsi3.S     |  2 +-
>> lib/builtins/arm/sync-ops.h   |  4 ++--
>> lib/builtins/arm/udivmodsi4.S |  2 +-
>> lib/builtins/arm/udivsi3.S    |  2 +-
>> lib/builtins/arm/umodsi3.S    |  2 +-
>> lib/builtins/assembly.h       | 11 +++++++++++
>> 12 files changed, 23 insertions(+), 12 deletions(-)
>> 
>> Steven
>> 
>> 
>> <thumb_func.patch>_______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits <http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141003/090cfc58/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: thumb_func.patch
Type: application/octet-stream
Size: 7439 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141003/090cfc58/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141003/090cfc58/attachment-0001.html>