Code review D5332

[Justin Hibbits]

Yes, the email address I use for phabricator is the same as this one.
The email is also shown in the llvm-commits archive at:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140908/235087.html
.  I'm not officially subscribed to here, but I guess I've emailed
enough times, and/or because this is the email address registered with
my llvm account, that I'm not getting bounces.

- Justin

On Fri, Oct 3, 2014 at 10:04 AM, David Blaikie <dblaikie at gmail.com> wrote:
> I don't see any other mail from you hitting the mailing list. Is the email
> address you used with Phabricator the same one you're using in this thread?
> (and/or if it's a different address, is that address subscribed to the
> llvm-commits mailing list)
>
> Without that subscription, the emails sent by phab will bounce off the
> mailing list since they impersonate your address (& thus need taht address
> to be subscribed to the mailing list).
>
> - David
>
> On Fri, Oct 3, 2014 at 8:33 AM, Justin Hibbits <jrh29 at alumni.cwru.edu>
> wrote:
>>
>> llvm-commits is on the subscribers list.  I tried putting it on the
>> reviewers list initially, but arc complained but allowed subscribers
>> (I see it in the llvm-commits archive, too). I'll ping the thread
>> directly, though.
>>
>> - Justin
>>
>> On Thu, 2 Oct 2014 23:57:38 -0700
>> David Blaikie <dblaikie at gmail.com> wrote:
>>
>> > Doesn't look like the llvm-commits mailing list was ever added to the
>> > reviewers.
>> >
>> > There's a particular quirk/problem with Phabricator reviews in
>> > particular if you don't create them with the mailing list added to
>> > the review on creation, then Phab never sends the proper introductory
>> > mail if you add the mailing list later (the introductory mail is only
>> > sent to those addresses the code review had at its creation).
>> > Generally it's best to cancel a review that ends up in this state
>> > (since you can't get Phab to produce that email) and start a new one.
>> >
>> > Beyond that, the usual recommendation is to 'ping' a review thread
>> > every week or so if it's not received attention. Some people are
>> > busy, etc, this is an easy way to remind them that there's something
>> > to do.
>> >
>> > So, my advice would be: cancel that review, create a new one and be
>> > sure to put all the reviewers and especially the mailing list
>> > (llvm-commits) on the review before you finish creating it. Make sure
>> > that initial mail is sent to (and arrives on) the llvm-commits
>> > mailing list. If there's no respons in a week, post a simple
>> > 'ping' (either via Phab or just reply-all to the original Phab
>> > mailing).
>> >
>> > On Thu, Oct 2, 2014 at 10:30 PM, Justin Hibbits
>> > <jrh29 at alumni.cwru.edu> wrote:
>> >
>> > > Can somebody please review http://reviews.llvm.org/D5332?  It's been
>> > > sitting idle for nearly 3 weeks now, and I want to get it in so
>> > > that my other patches can go in: D5399 and D5400 (PowerPC -fpic
>> > > support, and clang changes to support this, respectively).
>> > >
>> > > Thanks,
>> > > Justin
>
>