[PATCH] Make first of several changes to bring up to AArch64 fast-isel style
Daniel Sanders
daniel.sanders at imgtec.com
Fri Oct 3 06:44:36 PDT 2014
LGTM with a couple nits.
================
Comment at: lib/Target/Mips/MipsFastISel.cpp:53
@@ +52,3 @@
+ }
+ void setOffset(int64_t O) { Offset = O; }
+ int64_t getOffset() { return Offset; }
----------------
Nit: I realize the AArch64 code uses 'O' as well but please pick something else. It looks too much like '0'.
================
Comment at: lib/Target/Mips/MipsFastISel.cpp:54
@@ +53,3 @@
+ void setOffset(int64_t O) { Offset = O; }
+ int64_t getOffset() { return Offset; }
+ void setGlobalValue(const GlobalValue *G) { GV = G; }
----------------
Nit: Shouldn't this be const?
================
Comment at: lib/Target/Mips/MipsFastISel.cpp:138
@@ -125,1 +137,3 @@
+ // Backend specific FastISel code.
+ unsigned fastMaterializeConstant(const Constant *C) override;
----------------
Nit: Can you move this after the constructor?
http://reviews.llvm.org/D5595
More information about the llvm-commits
mailing list