[lld] r218846 - [lld] [ELF] [MIPS] Remove duplicate logic

[Rafael Auler]

Author: rafauler
Date: Wed Oct  1 20:30:29 2014
New Revision: 218846

URL: http://llvm.org/viewvc/llvm-project?rev=218846&view=rev
Log:
[lld] [ELF] [MIPS] Remove duplicate logic

Summary: With r218633, the logic that monitors which shared library symbols were used was copied from the MIPS lld backend to ELF classes, making it available to all ELF backends. However, this made the isDynSymEntryRequired() functions in MipsDynamicLibraryWriter.h/MipsELFWriters.h/MipsExecutableWriter.h to be duplicated logic, since this is already implemented in OutputELFWriter<>/DefaultLayout. This patch removes this duplicated code from MIPS.

Reviewers: Bigcheese, shankarke

Reviewed By: shankarke

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D5564

Modified:
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h?rev=218846&r1=218845&r2=218846&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h Wed Oct  1 20:30:29 2014
@@ -37,10 +37,6 @@ protected:
     return std::error_code();
   }
 
-  bool isDynSymEntryRequired(const SharedLibraryAtom *sla) const override {
-    return _writeHelper.isDynSymEntryRequired(sla);
-  }
-
   bool isNeededTagRequired(const SharedLibraryAtom *sla) const override {
     return _writeHelper.isNeededTagRequired(sla);
   }

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h?rev=218846&r1=218845&r2=218846&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsELFWriters.h Wed Oct  1 20:30:29 2014
@@ -69,10 +69,6 @@ public:
     return file;
   }
 
-  bool isDynSymEntryRequired(const SharedLibraryAtom *sla) const {
-    return _targetLayout.isReferencedByDefinedAtom(sla);
-  }
-
   bool isNeededTagRequired(const SharedLibraryAtom *sla) const {
     return _targetLayout.isReferencedByDefinedAtom(sla) ||
            _targetLayout.isCopied(sla);

Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h?rev=218846&r1=218845&r2=218846&view=diff
==============================================================================
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h (original)
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h Wed Oct  1 20:30:29 2014
@@ -38,10 +38,6 @@ protected:
     return std::error_code();
   }
 
-  bool isDynSymEntryRequired(const SharedLibraryAtom *sla) const override {
-    return _writeHelper.isDynSymEntryRequired(sla);
-  }
-
   bool isNeededTagRequired(const SharedLibraryAtom *sla) const override {
     return _writeHelper.isNeededTagRequired(sla);
   }