[PATCH] [lld] [ELF] [MIPS] Remove duplicate logic

Rafael Auler rafaelauler at gmail.com
Wed Oct 1 14:22:18 PDT 2014


Hi Bigcheese, shankarke,

With r218633, the logic that monitors which shared library symbols were used was copied from the MIPS lld backend to ELF classes, making it available to all ELF backends. However, this made the isDynSymEntryRequired() functions in MipsDynamicLibraryWriter.h/MipsELFWriters.h/MipsExecutableWriter.h to be duplicated logic, since this is already implemented in OutputELFWriter<>/DefaultLayout. This patch removes this duplicated code from MIPS.

http://reviews.llvm.org/D5564

Files:
  lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h
  lib/ReaderWriter/ELF/Mips/MipsELFWriters.h
  lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5564.14294.patch
Type: text/x-patch
Size: 1678 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141001/5b0c4da8/attachment.bin>


More information about the llvm-commits mailing list