[llvm] r218786 - LTO: Add missing target triple from r218784

Duncan P. N. Exon Smith dexonsmith at apple.com
Wed Oct 1 12:16:58 PDT 2014


Diego,

I aded the triple because -pass-remarks don't seem to work on x86_64-unknown-linux-gnu.

I.e., if you change the triple in this testcase to:

    target triple = "x86_64-unknown-linux-gnu"

The test fails like this:

Command Output (stderr):
--
/Volumes/Data/llvm/bugfixes/test/LTO/diagnostic-handler-remarks.ll:26:12: error: expected string not found in input
; REMARKS: remark:
           ^
<stdin>:1:1: note: scanning from here

^

--

Is this expected, or should I file a PR?

> On Oct 1, 2014, at 11:49 AM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> Author: dexonsmith
> Date: Wed Oct  1 13:49:58 2014
> New Revision: 218786
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=218786&view=rev
> Log:
> LTO: Add missing target triple from r218784
> 
> Modified:
>    llvm/trunk/test/LTO/diagnostic-handler-remarks.ll
> 
> Modified: llvm/trunk/test/LTO/diagnostic-handler-remarks.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/LTO/diagnostic-handler-remarks.ll?rev=218786&r1=218785&r2=218786&view=diff
> ==============================================================================
> --- llvm/trunk/test/LTO/diagnostic-handler-remarks.ll (original)
> +++ llvm/trunk/test/LTO/diagnostic-handler-remarks.ll Wed Oct  1 13:49:58 2014
> @@ -28,6 +28,8 @@
> ; NM-NOT: foo
> ; NM: main
> 
> +target triple = "x86_64-apple-darwin"
> +
> define i32 @foo() {
>   ret i32 7
> }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list