[PATCH] Improve big-endian support for ARM and AArch64

Charlie Turner charlie.turner at arm.com
Wed Oct 1 03:14:50 PDT 2014


Hi James,

>> if not 'hexagon' in config.target_triple:
>>    config.available_features.add("object-emission")
>
> So the tests when running on hexagon will not have the object-emission feature. So, you can add
>
>> REQUIRES: object-emission
>
> to the test case, under the RUN: line, to make it not run for hexagon.
>
> What am I missing?

Each target specific subdir has a lit.local.cfg file that prohibits the test from running on builds that don't have that target enabled. Since my tests are in target specific subdirs which are not Hexagon, "object-emission" is a default-enabled feature and so specifying it seems redundant.

11 out of the 121 tests in DebugInfo/X86 (for example) have REQUIRES: object-emission, and I think these are redundant uses of the guard, since 82 of the 121 tests require object emission and don't fail on the buildbots :)

I verified that my tests without REQUIRES: object-emission don't fail on a Hexagon host with both all targets enabled and just a hexagon target enabled. 

Thanks,
Charlie.








More information about the llvm-commits mailing list