[compiler-rt] r218716 - [compiler-rt] Re-enable the use of -gmlt for ASan tests on Darwin

Kuba Brecka kuba.brecka at gmail.com
Tue Sep 30 16:07:46 PDT 2014


Author: kuba.brecka
Date: Tue Sep 30 18:07:45 2014
New Revision: 218716

URL: http://llvm.org/viewvc/llvm-project?rev=218716&view=rev
Log:
[compiler-rt] Re-enable the use of -gmlt for ASan tests on Darwin

The optimization for -gmlt/-gline-tables-only introduced in r218129 happened to break on Darwin and produce no line number information due to
an incompatibility with dsymutil. ASan tests have been failing because of that and we disabled the use of -gmlt for the tests in r218545. This patch re-enables the use of -gmlt, because we have conditionally disabled the incompatible optimization in LLVM, so -gmlt now works on Darwin. Once Darwin's dsymutil is modified to allow this optimization, we can re-enable the optimization in LLVM.


Modified:
    compiler-rt/trunk/test/lit.common.cfg

Modified: compiler-rt/trunk/test/lit.common.cfg
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/lit.common.cfg?rev=218716&r1=218715&r2=218716&view=diff
==============================================================================
--- compiler-rt/trunk/test/lit.common.cfg (original)
+++ compiler-rt/trunk/test/lit.common.cfg Tue Sep 30 18:07:45 2014
@@ -25,12 +25,9 @@ if compiler_id == "Clang":
     config.cxx_mode_flags = ["--driver-mode=g++"]
   else:
     config.cxx_mode_flags = []
-  if config.host_os not in ['Darwin']:
-    # We assume that sanitizers should provide good enough error
-    # reports and stack traces even with minimal debug info.
-    config.debug_info_flags = ["-gline-tables-only"]
-  else:
-    config.debug_info_flags = ["-g"]
+  # We assume that sanitizers should provide good enough error
+  # reports and stack traces even with minimal debug info.
+  config.debug_info_flags = ["-gline-tables-only"]
 elif compiler_id == 'GNU':
   config.cxx_mode_flags = ["-x c++"]
   config.debug_info_flags = ["-g"]





More information about the llvm-commits mailing list