[LNT] r218635 - Fix name parsing in rerun code to handle test names with . in them
Chris Matthews
chris.matthews at apple.com
Tue Sep 30 15:36:09 PDT 2014
In r218701 I disabled the only way that a benchmark with this sort of name can happen. Now there is nothing to test!
> On Sep 30, 2014, at 9:37 AM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>
> Testcase?
>
>> On Sep 29, 2014, at 3:31 PM, Chris Matthews <cmatthews5 at apple.com> wrote:
>>
>> Author: cmatthews
>> Date: Mon Sep 29 17:31:40 2014
>> New Revision: 218635
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=218635&view=rev
>> Log:
>> Fix name parsing in rerun code to handle test names with . in them
>>
>> Modified:
>> lnt/trunk/lnt/tests/nt.py
>>
>> Modified: lnt/trunk/lnt/tests/nt.py
>> URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/nt.py?rev=218635&r1=218634&r2=218635&view=diff
>> ==============================================================================
>> --- lnt/trunk/lnt/tests/nt.py (original)
>> +++ lnt/trunk/lnt/tests/nt.py Mon Sep 29 17:31:40 2014
>> @@ -1279,8 +1279,15 @@ def _process_reruns(config, server_reply
>> for b in local_results.tests:
>> # format: suite.test/path/and/name.type<.type>
>> fields = b.name.split('.')
>> - test_name = fields[1]
>> - test_type = '.'.join(fields[2:])\
>> + test_suite = fields[0]
>> +
>> + test_type_size = -1
>> + if fields[-1] == "status":
>> + test_type_size = -2
>> +
>> + test_type = '.'.join(fields[test_type_size:])
>> +
>> + test_name = '.'.join(fields[1:test_type_size])
>>
>> updating_entry = collated_results.get(test_name,
>> PastRunData(test_name))
>> @@ -1299,7 +1306,9 @@ def _process_reruns(config, server_reply
>>
>> # Now add on top the server results to any entry we already have.
>> for full_name, results_status, perf_status in server_results:
>> - test_name, test_type = full_name.split(".")
>> + fields = full_name.split(".")
>> + test_name = '.'.join(fields[:-1])
>> + test_type = fields[-1]
>>
>> new_entry = collated_results.get(test_name, None)
>> # Some tests will come from the server, which we did not run locally.
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
More information about the llvm-commits
mailing list