[PATCH] demangle undefined symbol names in error message
Rui Ueyama
ruiu at google.com
Tue Sep 30 14:20:25 PDT 2014
LGTM with nits
================
Comment at: include/lld/Core/LinkingContext.h:274
@@ +273,3 @@
+ /// Formats symbol name for use in error messages.
+ virtual std::string demangleSymbol(StringRef symbolName) const {
+ return symbolName;
----------------
I'd name demangle rather than demangleSymbol because it's shorter and yet conveys enough information.
================
Comment at: include/lld/ReaderWriter/MachOLinkingContext.h:100
@@ -97,1 +99,3 @@
void setKeepPrivateExterns(bool v) { _keepPrivateExterns = v; }
+ bool demangle() const { return _demangle; }
+ void setDemangle(bool d) { _demangle = d; }
----------------
And rename doDemangle, enableDemangle or something like that.
http://reviews.llvm.org/D5549
More information about the llvm-commits
mailing list