[PATCH] WinCOFFObjectWriter: optimize the string table for common suffices
David Majnemer
david.majnemer at gmail.com
Mon Sep 29 13:18:19 PDT 2014
LGTM
================
Comment at: lib/MC/StringTableBuilder.cpp:31
@@ -29,2 +30,3 @@
+void StringTableBuilder::finalize(Kind kind) {
SmallVector<StringRef, 8> Strings;
for (auto i = StringIndexMap.begin(), e = StringIndexMap.end(); i != e; ++i)
----------------
Can we reserve space for `StringIndexMap.size()` number of `StringRef`s?
http://reviews.llvm.org/D5530
More information about the llvm-commits
mailing list