[compiler-rt] r218545 - Effectively revert r217284 on Darwin due to issues with -gmlt there

[Adrian Prantl]

> On Sep 29, 2014, at 11:28 AM, David Blaikie <dblaikie at gmail.com> wrote:
> 
> 
> 
> On Mon, Sep 29, 2014 at 6:17 AM, Alexander Potapenko <glider at google.com <mailto:glider at google.com>> wrote:
> On Sat, Sep 27, 2014 at 2:22 AM, David Blaikie <dblaikie at gmail.com <mailto:dblaikie at gmail.com>> wrote:
> >
> >
> > On Fri, Sep 26, 2014 at 2:58 PM, Alexey Samsonov <vonosmas at gmail.com <mailto:vonosmas at gmail.com>> wrote:
> >>
> >> Author: samsonov
> >> Date: Fri Sep 26 16:58:33 2014
> >> New Revision: 218545
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=218545&view=rev <http://llvm.org/viewvc/llvm-project?rev=218545&view=rev>
> >> Log:
> >> Effectively revert r217284 on Darwin due to issues with -gmlt there
> >
> >
> > Not sure if this is the right direction - but maybe I'm confused about what
> > was discussed in the other thread.
> >
> > I assume Apple uses/cares about -gmlt working on their platform and it
> > currently doesn't. (I could be wrong though - maybe they don't care about
> > -gmlt) This change would just paper over that.
> >
> > But if -gmlt's behavior on Apple isn't important to anyone, I'm fine with
> > this - keeps the code simpler on my side of things.
> >
> 
> Not sure about whether Apple cares about -gmlt (is that the new
> preferred name for -gline-tables-only?) or not, but without this
> change a bunch of asan tests has been failing on Darwin.
> 
> Yeah, I'm just concerned this'll suppress the failure but leave the bug. But I'll leave it to Apple folks to decide what they care about/priorities/timelines when it comes to -gmlt.

I’m a little confused now. Alexey, are the Darwin issues that you cited in the commit message the ones discussed in r218129 (dsymutil skipping compile units without subprograms?) or is this a separate issue? We definitely do care about -gmlt working on Darwin, and we also care about Asan working on Darwin.

-- adrian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140929/278bbc2c/attachment.html>