[llvm] r218544 - Remove definition of LLVM_VERSION_INFO; this macro is not used by any of the
Duncan P. N. Exon Smith
dexonsmith at apple.com
Fri Sep 26 17:46:27 PDT 2014
> On Sep 26, 2014, at 5:08 PM, Richard Smith <richard at metafoo.co.uk> wrote:
>
> On Fri, Sep 26, 2014 at 5:05 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> On Fri, Sep 26, 2014 at 4:55 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>
> > On Sep 26, 2014, at 4:49 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> >
> >> Your logic seems correct about it not working currently, but it looks
> >> like a bug that it's not included in `lto_get_version()`.
> >>
> >> Shouldn't we just fix it?
> >
> > Sure, if anyone cares.
>
> `ld64 -v` prints this out, so we care :). Thanks for noticing it!
>
> (I assume this is trivial to fix, but if not please CC me on a PR.)
>
> I don't know how to write a test for this, so someone else should probably tackle it. The way to fix it is to take the lines I removed from Makefile and CMakeLists.txt in tools/lto/ and add them to those files in lib/LTO/.
>
> Filed as PR21085.
Thanks!
More information about the llvm-commits
mailing list