[llvm] r218544 - Remove definition of LLVM_VERSION_INFO; this macro is not used by any of the

[Duncan P. N. Exon Smith]

> On Sep 26, 2014, at 2:53 PM, Richard Smith <richard-llvm at metafoo.co.uk> wrote:
> 
> Author: rsmith
> Date: Fri Sep 26 16:53:12 2014
> New Revision: 218544
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=218544&view=rev
> Log:
> Remove definition of LLVM_VERSION_INFO; this macro is not used by any of the
> files in this directory. If it should be defined anywhere, it should be defined
> when building lib/LTO/LTOCodeGenerator.cpp, but we've not had it defined there
> for quite some time, so that doesn't really seem to be very important. (It also
> would slow down the modules build by creating extra module variants.)
> 
> Modified:
>    llvm/trunk/tools/lto/CMakeLists.txt
>    llvm/trunk/tools/lto/Makefile

Your logic seems correct about it not working currently, but it looks
like a bug that it's not included in `lto_get_version()`.

Shouldn't we just fix it?

> Modified: llvm/trunk/tools/lto/CMakeLists.txt
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/CMakeLists.txt?rev=218544&r1=218543&r2=218544&view=diff
> ==============================================================================
> --- llvm/trunk/tools/lto/CMakeLists.txt (original)
> +++ llvm/trunk/tools/lto/CMakeLists.txt Fri Sep 26 16:53:12 2014
> @@ -6,8 +6,6 @@ set(LLVM_LINK_COMPONENTS
>   Support
>   )
> 
> -add_definitions( -DLLVM_VERSION_INFO=\"${PACKAGE_VERSION}\" )
> -
> set(SOURCES
>   LTODisassembler.cpp
>   lto.cpp
> 
> Modified: llvm/trunk/tools/lto/Makefile
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/lto/Makefile?rev=218544&r1=218543&r2=218544&view=diff
> ==============================================================================
> --- llvm/trunk/tools/lto/Makefile (original)
> +++ llvm/trunk/tools/lto/Makefile Fri Sep 26 16:53:12 2014
> @@ -17,10 +17,6 @@ EXPORTED_SYMBOL_FILE = $(PROJ_SRC_DIR)/l
> 
> include $(LEVEL)/Makefile.common
> 
> -ifdef LLVM_VERSION_INFO
> -CXX.Flags += -DLLVM_VERSION_INFO='"$(LLVM_VERSION_INFO)"'
> -endif
> -
> ifeq ($(HOST_OS),Darwin)
>     # Special hack to allow libLTO to have an offset version number.
>     ifdef LLVM_LTO_VERSION_OFFSET
>