[PATCH] Option to suppress the DWARF entries DW_AT_MIPS_linkage_name and DW_AT_linkage_name.

[Eric Christopher]

================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:45
@@ +44,3 @@
+static cl::opt<bool>
+SuppressLinkageNames("suppress-dwarf-linkage-names", cl::Hidden,
+                     cl::desc("Suppress the DWARF DW_AT_(MIPS_)?linkage_name entries"),
----------------
dblaikie wrote:
> I believe we're trying to move away from surfacing command line flags in this way for user-facing features. (see Chris Bieneman's work).
> 
> I'm not sure what the right answner is these days - this could be a flag on the compile_unit metadata - in which case it could be properly respected under LTO (if one CU was built with the flag and one built without it, it'd be possible/practical/easy to respect those differences, emitting linkage name for one CU and omitting it in another).
It's definitely a code gen option and so should go on a code gen option struct. That said, we're probably getting enough of them that a sub struct for debug info would be better.

i.e. I don't see why we'd want to handle adding or subtracting on a CU basis and thus need to put it on the metadata.

http://reviews.llvm.org/D5510