[PATCH] Extend C disassembler API to allow specifying target features
Renato Golin
renato.golin at linaro.org
Fri Sep 26 02:22:00 PDT 2014
================
Comment at: tools/llvm-c-test/disassemble.c:83
@@ -76,3 +82,3 @@
}
- do_disassemble(triple, disbuf, disbuflen);
+ do_disassemble(triple, features, disbuf, disbuflen);
}
----------------
bsmith wrote:
> rengolin wrote:
> > will there be any string validation further on? If yes, why do you do the NULL validation above? If not, shouldn't we add it?
> The feature string is passed straight through to createMCSubtargetInfo which I don't think accepts NULL as a value, there is certainty a lot of precedence in the codebase for using "" as an empty feature string instead of NULL.
right, so who passes "NULL"? Shouldn't that be an error?
http://reviews.llvm.org/D5468
More information about the llvm-commits
mailing list