[PATCH] [compiler-rt][builtins][MIPS] Add test-cases for mips16 wrappers for float arithmetic, comparison & conversion

Faraz Shahbazker Faraz.Shahbazker at imgtec.com
Thu Sep 25 20:34:29 PDT 2014


================
Comment at: test/builtins/Unit/mips/mips16_cmpdf2_test.c:18
@@ +17,3 @@
+
+// RUN: %clang_builtins -mips16 -g %s -o %t && %run %t
+
----------------
samsonov wrote:
> farazs wrote:
> > samsonov wrote:
> > > Who defines this substitution?
> > No one yet! I am hoping %clang_builtins would be defined by the test-framework, whenever the builtins testsuite is ported to LIT. That line is just a placeholder for now.
> Well, I'd rather not commit the test cases until they can actually be run. Defining this and providing lit-config substitution shouldn't be hard.
The intention of this line was to document that these specific test-cases need to be compiled with the option '-mips16'. I'll just remove the offending lines, they seem to cause unnecessary confusion.
Thanks.

http://reviews.llvm.org/D4453






More information about the llvm-commits mailing list