[PATCH] [sanitizer] Android build cleanup.
Evgeniy Stepanov
eugenis at google.com
Thu Sep 25 07:52:30 PDT 2014
================
Comment at: cmake/Modules/AddCompilerRT.cmake:46
@@ -45,3 +45,3 @@
# CFLAGS <compile flags>
# DEFS <compile definitions>)
macro(add_compiler_rt_runtime name arch type)
----------------
samsonov wrote:
> While you're here, please mention OUTPUT_NAME in the comment.
done
================
Comment at: lib/asan/tests/CMakeLists.txt:83
@@ +82,3 @@
+set(ASAN_UNITTEST_INSTRUMENTED_LIBS)
+if(ANDROID)
+ # NDK r10 requires -latomic almost always.
----------------
samsonov wrote:
> Consider using append_if here as well.
done
================
Comment at: lib/asan/tests/CMakeLists.txt:99
@@ +98,3 @@
+# TODO(eugenis): move all -l flags above to _LIBS?
+set(ASAN_NOINST_INSTRUMENTED_LIBS)
+if(ANDROID)
----------------
samsonov wrote:
> incorrect variable name: should be ASAN_UNITTEST_NOINST_LIBS
good catch
http://reviews.llvm.org/D5467
More information about the llvm-commits
mailing list