[PATCH] [MachineSink+PGO] Teach MachineSink to use BlockFrequencyInfo

Bruno Cardoso Lopes bruno.cardoso at gmail.com
Wed Sep 24 13:12:44 PDT 2014


Hi Manman,

> I am curious why you added a command line option with this updated patch, is
> it added just for writing a test case?

Not really, although it helps with checking both paths. I would like
to keep it around in the short-term to facilitate testing; other
people maybe also interested in double checking the results.

> Also did you measure any performance change without PGO but with your patch?

Not an extensive one yet, it's on my TODO list though. I've tested
with simple testcases and since MBFI uses loop info, even without PGO,
the loop depth info comes implicitly with the freq info, yielding very
similar results.

-- 
Bruno Cardoso Lopes
http://www.brunocardoso.cc



More information about the llvm-commits mailing list