[llvm] r218393 - Revert "Refactor the RelocVisitor::visit method"

[Renato Golin]

On 24 September 2014 18:49, Kaelyn Takata <rikka at google.com> wrote:
> Author: rikka
> Date: Wed Sep 24 12:49:07 2014
> New Revision: 218393
>
> URL: http://llvm.org/viewvc/llvm-project?rev=218393&view=rev
> Log:
> Revert "Refactor the RelocVisitor::visit method"
>
> This reverts commit faac033f7364bb4226e22c8079c221c96af10d02.

Hi Kaelyn,

Please don't revert patches just because it breaks one buildbot,
especially if the fix is obvious and only in the test. This makes it
hard to re-apply them later, and creates a lot of work for re-testing
on slow hardware.

I saw the email, I was fixing it, but when you reverted, I had to
start all over again. Next time, check the email, IRC or just mail the
person responsible, and let them fix it.

cheers,
--renato