[PATCH] [dwarfdump] Print the name for referenced specification of abstract_origin DIEs.

Alexey Samsonov vonosmas at gmail.com
Tue Sep 23 11:21:12 PDT 2014


Overall, I think that printing the name of referenced function makes sense and improves usability. I don't have strong opinion about the test cases (we should of course modify some of them to test the new behavior).

================
Comment at: lib/DebugInfo/DWARFDebugInfoEntry.cpp:129
@@ +128,3 @@
+      formValue.getForm() != DW_FORM_ref_sig8) {
+    uint32_t Ref = formValue.getAsReference(u).getValue();
+    DWARFDebugInfoEntryMinimal DIE;
----------------
instead of manually checking for DW_FORM_ref_sig8, can you check it like
  formValue.getAsReference(u).hasValue()
?

http://reviews.llvm.org/D5466






More information about the llvm-commits mailing list