[llvm] r218261 - Fix test case commited in r218242 to appease buildbot.

Duncan P. N. Exon Smith dexonsmith at apple.com
Tue Sep 23 11:06:08 PDT 2014


`X86MCAsmInfoDarwin::X86MCAsmInfoDarwin()` has this to say:

  // Use ## as a comment string so that .s files generated by llvm can go
  // through the GCC preprocessor without causing an error.  This is needed
  // because "clang foo.s" runs the C preprocessor, which is usually reserved
  // for .S files on other systems.  Perhaps this is because the file system
  // wasn't always case preserving or something.
  CommentString = "##";


> On 2014-Sep-22, at 12:53, Akira Hatanaka <ahatanak at gmail.com> wrote:
> 
> I see X86MCAsmInfoDarwin is using "##" for the CommentString, while the default is "#". I don't know why it has to be this way.
> 
> On Mon, Sep 22, 2014 at 11:58 AM, Robert Lougher <rob.lougher at gmail.com> wrote:
> Thanks for fixing this.  I was going to set an explicit triple, but
> this works as well (why does Darwin emit two hashes?).
> 
> Rob.
> 
> 
> On 22 September 2014 19:07, Akira Hatanaka <ahatanaka at apple.com> wrote:
> > Author: ahatanak
> > Date: Mon Sep 22 13:07:20 2014
> > New Revision: 218261
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=218261&view=rev
> > Log:
> > Fix test case commited in r218242 to appease buildbot.
> >
> >
> > Modified:
> >     llvm/trunk/test/CodeGen/X86/pshufb-mask-comments.ll
> >
> > Modified: llvm/trunk/test/CodeGen/X86/pshufb-mask-comments.ll
> > URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/pshufb-mask-comments.ll?rev=218261&r1=218260&r2=218261&view=diff
> > ==============================================================================
> > --- llvm/trunk/test/CodeGen/X86/pshufb-mask-comments.ll (original)
> > +++ llvm/trunk/test/CodeGen/X86/pshufb-mask-comments.ll Mon Sep 22 13:07:20 2014
> > @@ -4,7 +4,7 @@
> >
> >  define <16 x i8> @test1(<16 x i8> %V) {
> >  ; CHECK-LABEL: test1:
> > -; CHECK: pshufb {{.*}} # xmm0 = xmm0[1,0,0,0,0,2,0,0,0,0,3,0,0,0,0,4]
> > +; CHECK: pshufb {{.*}}# xmm0 = xmm0[1,0,0,0,0,2,0,0,0,0,3,0,0,0,0,4]
> >    %1 = tail call <16 x i8> @llvm.x86.ssse3.pshuf.b.128(<16 x i8> %V, <16 x i8> <i8 1, i8 0, i8 0, i8 0, i8 0, i8 2, i8 0, i8 0, i8 0, i8 0, i8 3, i8 0, i8 0, i8 0, i8 0, i8 4>)
> >    ret <16 x i8> %1
> >  }
> > @@ -13,7 +13,7 @@ define <16 x i8> @test1(<16 x i8> %V) {
> >
> >  define <16 x i8> @test2(<16 x i8> %V) {
> >  ; CHECK-LABEL: test2:
> > -; CHECK: pshufb {{.*}} # xmm0 = xmm0[15,0,0,0,0,0,0,0,0,0,1,0,0,0,0,2]
> > +; CHECK: pshufb {{.*}}# xmm0 = xmm0[15,0,0,0,0,0,0,0,0,0,1,0,0,0,0,2]
> >    %1 = tail call <16 x i8> @llvm.x86.ssse3.pshuf.b.128(<16 x i8> %V, <16 x i8> <i8 15, i8 0, i8 0, i8 0, i8 0, i8 16, i8 0, i8 0, i8 0, i8 0, i8 17, i8 0, i8 0, i8 0, i8 0, i8 50>)
> >    ret <16 x i8> %1
> >  }
> > @@ -22,7 +22,7 @@ define <16 x i8> @test2(<16 x i8> %V) {
> >
> >  define <16 x i8> @test3(<16 x i8> %V) {
> >  ; CHECK-LABEL: test3:
> > -; CHECK: pshufb {{.*}} # xmm0 = xmm0[1,0,0,15,0,2,0,0],zero,xmm0[0,3,0,0],zero,xmm0[0,4]
> > +; CHECK: pshufb {{.*}}# xmm0 = xmm0[1,0,0,15,0,2,0,0],zero,xmm0[0,3,0,0],zero,xmm0[0,4]
> >    %1 = tail call <16 x i8> @llvm.x86.ssse3.pshuf.b.128(<16 x i8> %V, <16 x i8> <i8 1, i8 0, i8 0, i8 127, i8 0, i8 2, i8 0, i8 0, i8 128, i8 0, i8 3, i8 0, i8 0, i8 255, i8 0, i8 4>)
> >    ret <16 x i8> %1
> >  }
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list