[PATCH] [X86] Make wide loads be managed by AtomicExpand

Robin Morisset morisset at google.com
Tue Sep 23 10:25:05 PDT 2014


================
Comment at: test/CodeGen/X86/atomic-load-store-wide.ll:1
@@ -1,2 +1,2 @@
 ; RUN: llc < %s -mcpu=corei7 -march=x86 -verify-machineinstrs | FileCheck %s
 
----------------
jfb wrote:
> Is there also a cmpxchg8b test for x86-64?
I do not understand this point, 64 bits accesses are naturally atomic on x86-64 (provided some alignment constraints are respected).
So there is no need for cmpxchg8b, and I do not know a case where they can be emitted by LLVM on x86-64.

================
Comment at: test/CodeGen/X86/atomic-load-store-wide.ll:9
@@ -8,2 +8,3 @@
+; CHECK: lock
 ; CHECK: cmpxchg8b
 ; CHECK-NEXT: jne
----------------
jfb wrote:
> Use `CHECK-LABEL` and `CHECK-NEXT`.
Thanks, fixed.

http://reviews.llvm.org/D5404






More information about the llvm-commits mailing list