[PATCH] [dwarfdump] Print the name for referenced specification of abstract_origin DIEs.

David Blaikie dblaikie at gmail.com
Tue Sep 23 08:47:32 PDT 2014


Looks fairly reasonable - not sure whether the test cases (if they pass without modifications) need updating. I'm undecided about if/how this feature will improve testing (in the existing cases, as you've kept, they really end up testing that the offsets actually refer to the desired DIE - I think that's valuable, rather than just testing the name (& at that point I'm not sure how much value we gain by testing the name as well)). What are your thoughts?

================
Comment at: test/DebugInfo/inline-scopes.ll:27
@@ -26,6 +26,3 @@
 ; CHECK-NOT: DW_TAG
-; CHECK-NOT: NULL
-; CHECK: DW_TAG_lexical_block
-; CHECK-NOT: DW_TAG
-; CHECK-NOT: NULL
-; CHECK: DW_TAG_variable
+; CHECK:   DW_AT_abstract_origin {{.*}} "_Z2f1v")
+; CHECK-NOT: {{DW_TAG|NULL}}
----------------
Why so many changes here? I assume this test would've passed unmodified even with your improvements (but I guess that's true of most of these test cases?)

http://reviews.llvm.org/D5466






More information about the llvm-commits mailing list