[PATCH] [SimplifyCFG] Double check for constant expression domination
Sergey Dmitrouk
sdmitrouk at accesssoftek.com
Tue Sep 23 01:35:23 PDT 2014
Hi resistor,
`isSafeToSpeculativelyExecute()` function contains more sophisticated checks
than `Constant::canTrap()`, so it appears to me that both functions should be
called to prevent optimizations that can harm.
I wasn't able to make a test, but absence of this check does cause trouble
with my local changes that disable certain kinds of optimizations to provide
IEEE754 conformant raising of FP exceptions, which I'd like to contribute.
http://reviews.llvm.org/D5459
Files:
lib/Transforms/Utils/SimplifyCFG.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5459.13976.patch
Type: text/x-patch
Size: 523 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140923/b632ec7a/attachment.bin>
More information about the llvm-commits
mailing list