[llvm] r218167 - DIBuilder: Delete dead code, NFC

[Duncan P. N. Exon Smith]

Thanks Fred, I'll have a look.  But if you get to it first go ahead and
delete it :).

I noticed `createObjCIVar()` because I hadn't found that node shape
with my upgrade scripts.

> On 2014-Sep-22, at 02:25, Frédéric Riss <friss at apple.com> wrote:
> 
> If it helps your porting effort to remove debug code in the DIBuilder, I believe createGlobalVariable is dead too. I’ve been meaning to send a patch removing it and renaming createStaticVariable to it for a little while, but never got around to do so.
> 
> Fred
> 
> 
>> On 20 Sep 2014, at 01:17, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
>> 
>> Author: dexonsmith
>> Date: Fri Sep 19 18:17:58 2014
>> New Revision: 218167
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=218167&view=rev
>> Log:
>> DIBuilder: Delete dead code, NFC
>> 
>> There are two versions of `DIBuilder::createObjCIVar()`.  Delete the one
>> that's apparently dead.
>> 
>> Modified:
>>   llvm/trunk/include/llvm/IR/DIBuilder.h
>>   llvm/trunk/lib/IR/DIBuilder.cpp
>> 
>> Modified: llvm/trunk/include/llvm/IR/DIBuilder.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/DIBuilder.h?rev=218167&r1=218166&r2=218167&view=diff
>> ==============================================================================
>> --- llvm/trunk/include/llvm/IR/DIBuilder.h (original)
>> +++ llvm/trunk/include/llvm/IR/DIBuilder.h Fri Sep 19 18:17:58 2014
>> @@ -232,32 +232,6 @@ namespace llvm {
>>    /// @param OffsetInBits Member offset.
>>    /// @param Flags        Flags to encode member attribute, e.g. private
>>    /// @param Ty           Parent type.
>> -    /// @param PropertyName Name of the Objective C property associated with
>> -    ///                     this ivar.
>> -    /// @param PropertyGetterName Name of the Objective C property getter
>> -    ///                           selector.
>> -    /// @param PropertySetterName Name of the Objective C property setter
>> -    ///                           selector.
>> -    /// @param PropertyAttributes Objective C property attributes.
>> -    DIDerivedType createObjCIVar(StringRef Name, DIFile File,
>> -                                 unsigned LineNo, uint64_t SizeInBits,
>> -                                 uint64_t AlignInBits, uint64_t OffsetInBits,
>> -                                 unsigned Flags, DIType Ty,
>> -                                 StringRef PropertyName = StringRef(),
>> -                                 StringRef PropertyGetterName = StringRef(),
>> -                                 StringRef PropertySetterName = StringRef(),
>> -                                 unsigned PropertyAttributes = 0);
>> -
>> -    /// createObjCIVar - Create debugging information entry for Objective-C
>> -    /// instance variable.
>> -    /// @param Name         Member name.
>> -    /// @param File         File where this member is defined.
>> -    /// @param LineNo       Line number.
>> -    /// @param SizeInBits   Member size.
>> -    /// @param AlignInBits  Member alignment.
>> -    /// @param OffsetInBits Member offset.
>> -    /// @param Flags        Flags to encode member attribute, e.g. private
>> -    /// @param Ty           Parent type.
>>    /// @param PropertyNode Property associated with this ivar.
>>    DIDerivedType createObjCIVar(StringRef Name, DIFile File,
>>                                 unsigned LineNo, uint64_t SizeInBits,
>> 
>> Modified: llvm/trunk/lib/IR/DIBuilder.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/DIBuilder.cpp?rev=218167&r1=218166&r2=218167&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/IR/DIBuilder.cpp (original)
>> +++ llvm/trunk/lib/IR/DIBuilder.cpp Fri Sep 19 18:17:58 2014
>> @@ -469,34 +469,6 @@ DIBuilder::createStaticMemberType(DIDesc
>> 
>> /// createObjCIVar - Create debugging information entry for Objective-C
>> /// instance variable.
>> -DIDerivedType
>> -DIBuilder::createObjCIVar(StringRef Name, DIFile File, unsigned LineNumber,
>> -                          uint64_t SizeInBits, uint64_t AlignInBits,
>> -                          uint64_t OffsetInBits, unsigned Flags, DIType Ty,
>> -                          StringRef PropertyName, StringRef GetterName,
>> -                          StringRef SetterName, unsigned PropertyAttributes) {
>> -  // TAG_member is encoded in DIDerivedType format.
>> -  Value *Elts[] = {
>> -    GetTagConstant(VMContext, dwarf::DW_TAG_member),
>> -    File.getFileNode(),
>> -    getNonCompileUnitScope(File),
>> -    MDString::get(VMContext, Name),
>> -    ConstantInt::get(Type::getInt32Ty(VMContext), LineNumber),
>> -    ConstantInt::get(Type::getInt64Ty(VMContext), SizeInBits),
>> -    ConstantInt::get(Type::getInt64Ty(VMContext), AlignInBits),
>> -    ConstantInt::get(Type::getInt64Ty(VMContext), OffsetInBits),
>> -    ConstantInt::get(Type::getInt32Ty(VMContext), Flags),
>> -    Ty,
>> -    MDString::get(VMContext, PropertyName),
>> -    MDString::get(VMContext, GetterName),
>> -    MDString::get(VMContext, SetterName),
>> -    ConstantInt::get(Type::getInt32Ty(VMContext), PropertyAttributes)
>> -  };
>> -  return DIDerivedType(MDNode::get(VMContext, Elts));
>> -}
>> -
>> -/// createObjCIVar - Create debugging information entry for Objective-C
>> -/// instance variable.
>> DIDerivedType DIBuilder::createObjCIVar(StringRef Name, DIFile File,
>>                                        unsigned LineNumber,
>>                                        uint64_t SizeInBits,
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>