[PATCH] ms-inline-asm: Fix parsing label names inside bracket expressions

Ehsan Akhgari ehsan.akhgari at gmail.com
Mon Sep 22 12:50:56 PDT 2014


Hi rnk,

This fixes a couple of issues.  One is ensuring that AOK_Label rewrite
rules have a lower priority than AOK_Skip rules, as AOK_Skip needs to
be able to skip the brackets properly.  The other part of the fix ensures
that we don't overwrite Identifier when looking up the identifier, and
that we use the locally available information to generate the AOK_Label
rewrite in ParseIntelIdentifier.  Doing that in CreateMemForInlineAsm
would be problematic since the Start location there may point to the
beginning of a bracket expression, and not necessarily the beginning of
an identifier.

This also means that we don't need to carry around the InternlName field,
which helps simplify the code.

http://reviews.llvm.org/D5445

Files:
  include/llvm/MC/MCParser/MCAsmParser.h
  include/llvm/MC/MCTargetAsmParser.h
  lib/Target/X86/AsmParser/X86AsmParser.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D5445.13949.patch
Type: text/x-patch
Size: 2847 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140922/702b1726/attachment.bin>


More information about the llvm-commits mailing list