[PATCH] [ASan] Introduce the dump_instruction_bytes flag to print the faulting instruction upon SIGSEGV

Alexey Samsonov vonosmas at gmail.com
Fri Sep 19 16:52:01 PDT 2014


LGTM

================
Comment at: lib/asan/asan_report.cc:168
@@ +167,3 @@
+    for (int i = 0; i < 16; ++i) {
+      PrintMemoryByte(&str, "", ((char *)pc)[i], /*in_shadow*/false, " ");
+    }
----------------
s/char/u8 ?

http://reviews.llvm.org/D5167






More information about the llvm-commits mailing list