[PATCH] Allow DWARFDebugInfoEntryMinimal::getSubroutineName to resolve cross-unit references.

Alexey Samsonov vonosmas at gmail.com
Fri Sep 19 16:47:54 PDT 2014


LGTM. Thanks!

================
Comment at: lib/DebugInfo/DWARFDebugInfoEntry.cpp:31
@@ +30,3 @@
+  Unit = Unit->getUnitSection().getUnitForOffset(*Offset);
+  return Unit && DIE.extractFast(Unit, Offset) ? Unit : nullptr;
+}
----------------
Please put parentheses around
  Unit && DIE.extractFast(Unit, Offset)

http://reviews.llvm.org/D5394






More information about the llvm-commits mailing list