[PATCH] [PATCH][SROA]Also slice the STORE when slicing a LOAD in AllocaSliceRewriter

Chandler Carruth chandlerc at google.com
Thu Sep 18 23:51:30 PDT 2014


On Thu, Sep 18, 2014 at 11:43 PM, Hao Liu <Hao.Liu at arm.com> wrote:

> Hi all,
>
>
>
> Thanks for the code review. I’ve learnt a lot.
>
> Now I think I agree with Chandler, sometimes wide store is better than two
> narrow stores. I’ve attached the test cases.
>

FWIW, yes, this is why code review is awesome. We all learn through them.
=] And these are really nice, small test cases to explain the underlying
issues. Thanks for those, I think they help highlight things.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140918/f45b6f18/attachment.html>


More information about the llvm-commits mailing list