[PATCH][AArch64] Enable access to the whole MRS/MSR system reg encoding space

Jim Grosbach grosbach at apple.com
Thu Sep 18 09:55:24 PDT 2014


Huh. I thought we already did that for exactly the reasons you state. In any case, sounds reasonable to me. Patch looks fine, please commit.

-Jim

> On Sep 18, 2014, at 6:57 AM, Tom Coxon <tom.coxon at arm.com> wrote:
> 
> Hi all,
> 
> The attached patch enables access to the whole space of ARMv8-A system registers through the S<op0>_<op1>_<Cn>_<Cm>_<op2> syntax.
> 
> This is useful to anyone needing to write assembly code supporting new system registers before the assembler has learned the official names for them.
> 
> Although this is a real use case, it is niche and most users should still use the official system registers names. In order to avoid encouraging general use of this syntax, ARM is not planning to document this in the ARMARM.
> 
> Regards,
> Tom
> 
> Files changed:
> lib/Target/AArch64/AArch64InstrFormats.td          |   12 +++----
> .../AArch64/Disassembler/AArch64Disassembler.cpp   |   24 +++----------
> .../AArch64/InstPrinter/AArch64InstPrinter.cpp     |   12 +++----
> lib/Target/AArch64/Utils/AArch64BaseInfo.cpp       |   36 +++++++-------------
> lib/Target/AArch64/Utils/AArch64BaseInfo.h         |    2 +-
> test/MC/AArch64/arm64-system-encoding.s            |    4 +++
> test/MC/AArch64/basic-a64-diagnostics.s            |   16 ++++-----
> test/MC/AArch64/basic-a64-instructions.s           |    8 +++--
> 8 files changed, 44 insertions(+), 70 deletions(-)
> <0001-AArch64-Allow-access-to-all-system-registers-with-MR.patch>




More information about the llvm-commits mailing list