[polly] r218052 - Report possible aliasing deterministically

Tobias Grosser tobias at grosser.es
Thu Sep 18 07:45:43 PDT 2014


Author: grosser
Date: Thu Sep 18 09:45:43 2014
New Revision: 218052

URL: http://llvm.org/viewvc/llvm-project?rev=218052&view=rev
Log:
Report possible aliasing deterministically

This commit drops a call to std::sort, which sorted the base pointers that
possibly alias according to the address at which their corresponding llvm::Value
was allocated. There does not seem to be any good reason, why those pointers
should be (re)sorted and this only makes the output indeterministic.

Modified:
    polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp
    polly/trunk/test/ScopDetectionDiagnostics/ReportAlias-01.ll

Modified: polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp?rev=218052&r1=218051&r2=218052&view=diff
==============================================================================
--- polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp (original)
+++ polly/trunk/lib/Analysis/ScopDetectionDiagnostic.cpp Thu Sep 18 09:45:43 2014
@@ -475,8 +475,6 @@ std::string ReportAlias::formatInvalidAl
 
   OS << Prefix;
 
-  std::sort(Pointers.begin(), Pointers.end());
-
   for (PointerSnapshotTy::const_iterator PI = Pointers.begin(),
                                          PE = Pointers.end();
        ;) {

Modified: polly/trunk/test/ScopDetectionDiagnostics/ReportAlias-01.ll
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/test/ScopDetectionDiagnostics/ReportAlias-01.ll?rev=218052&r1=218051&r2=218052&view=diff
==============================================================================
--- polly/trunk/test/ScopDetectionDiagnostics/ReportAlias-01.ll (original)
+++ polly/trunk/test/ScopDetectionDiagnostics/ReportAlias-01.ll Thu Sep 18 09:45:43 2014
@@ -6,7 +6,7 @@
 ;}
 
 ; CHECK: remark: ReportAlias-01.c:2:8: The following errors keep this region from being a Scop.
-; CHECK: remark: ReportAlias-01.c:3:5: Accesses to the arrays "A", "B" may access the same memory.
+; CHECK: remark: ReportAlias-01.c:3:5: Accesses to the arrays "B", "A" may access the same memory.
 ; CHECK: remark: ReportAlias-01.c:3:5: Invalid Scop candidate ends here.
 
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"





More information about the llvm-commits mailing list