[llvm] r217985 - [llvm-objdump] clean up test cases now that build bots are green

Rafael EspĂ­ndola rafael.espindola at gmail.com
Thu Sep 18 07:40:35 PDT 2014


Thanks!

BTW, any reason for adding this to llvm-objdump instead of llvm-readobj?

The rule of the thumb is that llvm-readobj is whatever we want it to
be for testing. llvm-objdump is intended as user tool, a replacement
for the system objdump.


On 17 September 2014 17:53, Nick Kledzik <kledzik at apple.com> wrote:
> Author: kledzik
> Date: Wed Sep 17 16:53:07 2014
> New Revision: 217985
>
> URL: http://llvm.org/viewvc/llvm-project?rev=217985&view=rev
> Log:
> [llvm-objdump] clean up test cases now that build bots are green
>
> Modified:
>     llvm/trunk/test/tools/llvm-objdump/macho-bind.test
>     llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test
>     llvm/trunk/test/tools/llvm-objdump/macho-weak-bind.test
>
> Modified: llvm/trunk/test/tools/llvm-objdump/macho-bind.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/macho-bind.test?rev=217985&r1=217984&r2=217985&view=diff
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objdump/macho-bind.test (original)
> +++ llvm/trunk/test/tools/llvm-objdump/macho-bind.test Wed Sep 17 16:53:07 2014
> @@ -1,6 +1,5 @@
> -# RUN: llvm-objdump -macho -bind -arch x86_64 %p/Inputs/bind.macho-x86_64 > %t
> -# RUN: cat %t
> -# RUN: FileCheck %s < %t
> +# RUN: llvm-objdump -macho -bind %p/Inputs/bind.macho-x86_64 \
> +# RUN:   | FileCheck %s
>
>
>  # CHECK:__DATA   __data             0x00001028  pointer  0        flat-namespace      _any
>
> Modified: llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test?rev=217985&r1=217984&r2=217985&view=diff
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test (original)
> +++ llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test Wed Sep 17 16:53:07 2014
> @@ -1,6 +1,5 @@
> -# RUN: llvm-objdump -macho -lazy-bind -arch x86_64 \
> -# RUN:   %p/Inputs/lazy-bind.macho-x86_64 > %t \
> -# RUN: && FileCheck %s < %t || cat %t
> +# RUN: llvm-objdump -macho -lazy-bind %p/Inputs/lazy-bind.macho-x86_64 \
> +# RUN:   | FileCheck %s
>
>
>  # CHECK: __DATA   __la_symbol_ptr    0x100001010   libfoo          _foo
>
> Modified: llvm/trunk/test/tools/llvm-objdump/macho-weak-bind.test
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/macho-weak-bind.test?rev=217985&r1=217984&r2=217985&view=diff
> ==============================================================================
> --- llvm/trunk/test/tools/llvm-objdump/macho-weak-bind.test (original)
> +++ llvm/trunk/test/tools/llvm-objdump/macho-weak-bind.test Wed Sep 17 16:53:07 2014
> @@ -1,5 +1,5 @@
> -# RUN: llvm-objdump -macho -weak-bind -arch x86_64 \
> -# RUN:   %p/Inputs/weak-bind.macho-x86_64 | FileCheck %s
> +# RUN: llvm-objdump -macho -weak-bind  %p/Inputs/weak-bind.macho-x86_64 \
> +# RUN:   | FileCheck %s
>
>
>  # CHECK: __DATA   __data             0x100001018   pointer  0        __ZTISt12out_of_range
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list