[PATCH] [Profile] adding support for MIPS32/MIPS64
Mohit Bhakkad
mohit.bhakkad at imgtec.com
Wed Sep 17 03:49:28 PDT 2014
================
Comment at: cmake/config-ix.cmake:82
@@ -81,3 +81,3 @@
list(APPEND COMPILER_RT_SUPPORTED_ARCH ${arch})
- elseif("${COMPILER_RT_TEST_TARGET_ARCH}" MATCHES "${arch}" OR
+ elseif("${COMPILER_RT_TEST_TARGET_ARCH}" STREQUAL "${arch}" OR
"${arch}" STREQUAL "arm_android")
----------------
Defination of CMake if(MATCHES) command is
if(<variable|string> MATCHES regex)
Which can be ambiguous because of regex as an operand.
Whereas for CMake if(STREQUAL) exact lexicographical comparison between left and right operand is done;
if(<variable|string> STREQUAL <variable|string>)
source: http://www.cmake.org/cmake/help/v3.0/command/if.html
http://reviews.llvm.org/D4880
More information about the llvm-commits
mailing list