reset method for WinCOFFObjectWriter

[Yaron Keren]

Committed revision 217948.

2014-09-17 1:35 GMT+03:00 Reid Kleckner <rnk at google.com>:

> lgtm


On Tue, Sep 16, 2014 at 2:46 PM, Yaron Keren <yaron.keren at gmail.com> wrote:

> Thanks, committed r217907.
>
> Here are few more of the same kind, please review.
>
> Yaron
>
>
> 2014-09-16 23:11 GMT+03:00 Reid Kleckner <rnk at google.com>:
>
>> Yep, go for it.
>
>
> On Tue, Sep 16, 2014 at 11:54 AM, Yaron Keren <yaron.keren at gmail.com>
> wrote:
>
>> Hi Reid,
>>
>> Is this good to commit?
>>
>> Yaron
>>
>>
>> 2014-09-16 0:12 GMT+03:00 Owen Anderson <resistor at mac.com>:
>>
>>>
>>> On Sep 15, 2014, at 1:23 PM, Yaron Keren <yaron.keren at gmail.com> wrote:
>>>
>>> I don't know if there are other users of PassManager that keep it alive,
>>> so doFinalization() and reset() sufferred code rot with regard to reseting
>>> state. Most are OK but pieces are missing here and threre. Keeping this
>>> existing structure alive will enable reusing the passManager.
>>>
>>>
>>> We make use of this exact functionality, and test it internally for the
>>> use cases we care about.  Unfortunately, that does not include COFF support.
>>>
>>> --Owen
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140917/0f609d34/attachment.html>