[llvm] r217856 - tweak test case to help solve why failing on one build bot

[Rafael Espíndola]

On 16 September 2014 17:07, Nick Kledzik <kledzik at apple.com> wrote:
>
> On Sep 16, 2014, at 2:02 PM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>
>> On 15 September 2014 22:33, Nick Kledzik <kledzik at apple.com> wrote:
>>> Author: kledzik
>>> Date: Mon Sep 15 21:33:36 2014
>>> New Revision: 217856
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=217856&view=rev
>>> Log:
>>> tweak test case to help solve why failing on one build bot
>>>
>>> Modified:
>>>    llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test
>>>
>>> Modified: llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test?rev=217856&r1=217855&r2=217856&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test (original)
>>> +++ llvm/trunk/test/tools/llvm-objdump/macho-lazy-bind.test Mon Sep 15 21:33:36 2014
>>> @@ -1,5 +1,6 @@
>>> # RUN: llvm-objdump -macho -lazy-bind -arch x86_64 \
>>> -# RUN:   %p/Inputs/lazy-bind.macho-x86_64 | FileCheck %s
>>> +# RUN:   %p/Inputs/lazy-bind.macho-x86_64 > %t \
>>> +# RUN: && FileCheck %s < %t || cat %t
>>
>> What was the error? This (and r217860) look really odd. Why do you
>> need the &&? Every other test with multiple commands looks like
>>
>> ; RUN: cmd1
>> ; RUN: cmd2
>
> The s390x linux build bot (and just that one bot) was failing on the initial test.  I was trying to get it to dump out what llvm-objdump was producing that FileCheck did not like.  But it seems that you only see output in the build bot logs if the test fails.   So, I still don’t know why s390x is failing…  Any ideas?

How about

# RUN: llvm-objdump -macho -lazy-bind -arch x86_64 \
# RUN:   %p/Inputs/lazy-bind.macho-x86_64 > %t
# RUN: cat %t
# RUN:  FileCheck %s < %t