[PATCH] WIP: DI: Fold constant arguments into a single MDString

[Eric Christopher]

For the record I like this as a first start. Thanks for the work Duncan.

-eric

On Tue, Sep 9, 2014 at 3:04 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> This patch addresses the first stage of PR17891 by folding constant
> arguments together into a single MDString.  Integers are stringified and
> a `\0` character is used as a separator.
>
> ----
>
> Known defects:
>
>   - I've only barely started to update testcases.
>   - There are bound to be bugs ~~~~~~~~~~~~^
>   - I deleted dead code (I'll separate that out before committing).
>
> I'd really appreciate some early feedback on this nevertheless.  I'm
> finding the testcases painful enough to update that I don't want to do it
> twice.
>
>  1. I think `\0` is cleaner than `,`.  Bike shed?
>
>  2. I'm using hex for the tags.  Good idea?
>
>  3. I didn't add a prefix, which David suggested just now in PR17891.
>     This would be the time to do it, but is the hex tag sufficient?
>
>  4. Anything (other than testcases) I've missed updating?
>
>  5. Do you have specific advice on automating the testcase update flow?
>     My next step is building tool support, so suggestions (and starter
>     scripts) are welcome.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140916/aa8dff4c/attachment.html>