[PATCH] Rename getNoopForMachoTarget to getNoop

[Jim Grosbach]

> On Sep 16, 2014, at 8:32 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> 
> On 15 September 2014 23:36, Brad Smith <brad at comstyle.com> wrote:
>> On 15/09/14 5:39 PM, Jim Grosbach wrote:
>>> 
>>> 
>>>> On Sep 15, 2014, at 12:50 PM, Brad Smith <brad at comstyle.com> wrote:
>>>> 
>>>> On 15/09/14 2:45 PM, Rafael Espíndola wrote:
>>>>> 
>>>>> On 15 September 2014 14:39, Brad Smith <brad at comstyle.com> wrote:
>>>>>> 
>>>>>> On 15/09/14 1:19 PM, Rafael Espíndola wrote:
>>>>>>> 
>>>>>>> 
>>>>>>> I think this is wrong. We should just produce empty functions for
>>>>>>> non-MachO.
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> Then send a diff to do it.
>>>>> 
>>>>> 
>>>>> Fixed. In the future, do *not* commit patches without approval.
>>>> 
>>>> 
>>>> It was approved.
>>> 
>>> 
>>> Where? I just re-read the thread and don’t see it. Is there somewhere else
>>> I should be looking?
>> 
>> 
>> Since this diff wasn't even commited I'm assuming he wasn't talking about
>> this diff thus looking through this thread won't be of any use.
> 
> I was referring to r217611.

That explains it! Thanks, guys.

-Jim


> 
> Cheers,
> Rafael

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140916/bc9ac9bb/attachment.html>