[PATCH] Enable Asan on Windows

Amine Khaldi amine.khaldi at reactos.org
Tue Sep 16 07:01:21 PDT 2014


================
Comment at: lib/asan/CMakeLists.txt:200
@@ +199,3 @@
+      else()
+        set(OMIT_DEFAULT_LIB_NAME_FLAG "")
+      endif()
----------------
timurrrr wrote:
> Is there an equivalent of /Zl (Omit Default Library Name) in non-MSVC compilers?
Hmm I don't think so, it looks pretty MSVC centric.

================
Comment at: lib/asan/asan_win_dll_thunk.cc:27
@@ +26,3 @@
+#ifdef _MSC_VER
+#define ABORT __debugbreak()
+#else
----------------
timurrrr wrote:
> maybe `DEBUG_BREAK` is more appropriate, what do you think?
It's more descriptive, okay.

http://reviews.llvm.org/D5367






More information about the llvm-commits mailing list