[llvm] r217855 - [x86] Remove a FIXME that doesn't make any sense. Only the lanes feeding

Chandler Carruth chandlerc at gmail.com
Mon Sep 15 19:16:42 PDT 2014


Author: chandlerc
Date: Mon Sep 15 21:16:42 2014
New Revision: 217855

URL: http://llvm.org/viewvc/llvm-project?rev=217855&view=rev
Log:
[x86] Remove a FIXME that doesn't make any sense. Only the lanes feeding
the blend that is matched by this are "used" in any sense, and so any
build_vector or other nodes feeding these will already drop other lanes.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=217855&r1=217854&r2=217855&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Mon Sep 15 21:16:42 2014
@@ -20033,9 +20033,6 @@ static SDValue combineShuffleToAddSub(SD
           VT == MVT::v4f64) &&
          "Unknown vector type encountered!");
 
-  // FIXME: Munge the inputs through no-op shuffles that drop the undef lanes to
-  // allow nuking any instructions that feed only those lanes.
-
   return DAG.getNode(X86ISD::ADDSUB, DL, VT, LHS, RHS);
 }
 





More information about the llvm-commits mailing list